userID: break out EID configuration to individual submodules #10229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
approved these changes
Jul 14, 2023
|
Nice! |
|
this is great! LGTM |
santii7395
pushed a commit
to themaven-net/Prebid.js
that referenced
this pull request
Aug 28, 2023
…10229) * move eids config to submodules * update EID logic * Fix tests
3link
reviewed
Sep 22, 2023
| @@ -242,6 +242,59 @@ export const liveIntentIdSubmodule = { | |||
| } | |||
|
|
|||
| return { callback: result }; | |||
| }, | |||
| eids: { | |||
There was a problem hiding this comment.
@dgirardi I have a question related to changes in this PR: LiveIntent's user id module can also provide uid2s, but in case the uid2idSystem is not part of the Prebid built, it will be impossible to convert them into the eids.
What should the intended usage pattern be in general? Is it "if you want an id of a certain type to be provided by a 'secondary' provider, you must have the 'main' provider too"? Or is it not the intention and LiveIntent's user id module should have a recipe for converting uid2s into eids?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Closes #9786